Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: latest pytest version breaking tests #1507

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Jun 7, 2024

Description

On 6/4, pytest released a new version == 8.2.2, which caused several of the E2E and unit tests to fail with an AssertionError "assert testcase is not None". This changes to install a compatible version of pytest. 7.4.4 is the latest version we can pin to, as the 8.* versions are not supported in python 3.7.

For example:

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@hallvictoria hallvictoria marked this pull request as ready for review June 7, 2024 18:44
@YunchuWang
Copy link
Member

nit: add broken pipeline link to this pr for easy tracking if needed in future

@hallvictoria hallvictoria merged commit 2f65a2f into dev Jun 7, 2024
64 of 67 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/e2e-pytest-fix branch June 7, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants